Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add yfm-cut extension #1

Merged
merged 3 commits into from
Jul 31, 2024
Merged

add yfm-cut extension #1

merged 3 commits into from
Jul 31, 2024

Conversation

d3m1d0v
Copy link
Member

@d3m1d0v d3m1d0v commented Jul 12, 2024 •
edited
Loading

Move yfm-cut plugin from transformer to separate extension and npm-package

d3m1d0v
d3m1d0v commented Jul 23, 2024
View reviewed changes
src/plugin/plugin.ts
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied from https://github.com/diplodoc-platform/transform/blob/13459466b326f185cc54d855cee32e9f9381e70a/src/transform/plugins/cut.ts

src/runtime/contoller.ts
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rewrited from https://github.com/diplodoc-platform/transform/blob/13459466b326f185cc54d855cee32e9f9381e70a/src/js/cut.ts

src/runtime/styles/cut.scss
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied from https://github.com/diplodoc-platform/transform/blob/13459466b326f185cc54d855cee32e9f9381e70a/src/scss/_cut.scss

tests/plugin.test.ts
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied from https://github.com/diplodoc-platform/transform/blob/13459466b326f185cc54d855cee32e9f9381e70a/src/scss/_cut.scss

And added several specific tests for the extension

@d3m1d0v d3m1d0v requested review from makhnatkin and 3y3 July 23, 2024 06:57
@d3m1d0v d3m1d0v marked this pull request as ready for review July 23, 2024 06:58
@d3m1d0v d3m1d0v merged commit e12872b into main Jul 31, 2024
2 checks passed
@d3m1d0v d3m1d0v deleted the cut-extension branch July 31, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makhnatkin makhnatkin makhnatkin approved these changes

@3y3 3y3 Awaiting requested review from 3y3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d3m1d0v @makhnatkin